Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added description for server #122

Merged
merged 17 commits into from
Jan 27, 2024
Merged

Added description for server #122

merged 17 commits into from
Jan 27, 2024

Conversation

Dashboy1998
Copy link
Contributor

Context

  • Add a description to the server

Choices

  • Implemented the same as the other settings

Test instructions

  1. Set a description in docker-compose
  2. Start container
  3. Join game
  4. Go to the options in game to see the description. For my testing I did Hello World.
    20240125214337_1

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the README.
  • I've not introduced breaking changes.

@fryfrog
Copy link
Contributor

fryfrog commented Jan 26, 2024

You should wait for #124 to be merged, then update your changes to incorporate it. The current way does not support spaces in the server name and wouldn't in the description.

@Dashboy1998
Copy link
Contributor Author

You should wait for #124 to be merged, then update your changes to incorporate it. The current way does not support spaces in the server name and wouldn't in the description.

I didn't have any issues with spaces in the server name or description as and that can be seen in the photo in the PR.

thijsvanloef
thijsvanloef requested changes Jan 26, 2024
View reviewed changes
Copy link
Owner

@thijsvanloef thijsvanloef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just merged #124, if you are able to, please change the way -serverdescription gets added to the STARTCOMMAND.

@thijsvanloef
Copy link
Owner

Needed to revert #124, your PR is still on my radar, but #124 has to be fixed first, sorry for the inconvenience.

@thijsvanloef
Copy link
Owner

There was some fuckery going on with the revert, I believe I fixed it

Dashboy1998
Dashboy1998 commented Jan 27, 2024
View reviewed changes
docker-compose.yml Outdated Show resolved Hide resolved
@thijsvanloef thijsvanloef merged commit 7189764 into thijsvanloef:main Jan 27, 2024
4 checks passed
@Dashboy1998 Dashboy1998 deleted the Server-Description branch January 28, 2024 12:46
@Dashboy1998 Dashboy1998 restored the Server-Description branch January 28, 2024 12:57
MusclePr pushed a commit to MusclePr/palworld-server-docker that referenced this pull request Jun 19, 2024
@thijsvanloef
Merge pull request thijsvanloef#122 from Dashboy1998/Server-Description
4ffdc7c 
Added description for server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thijsvanloef thijsvanloef Awaiting requested review from thijsvanloef

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dashboy1998 @fryfrog @thijsvanloef